UUDigitalHumanitieslab / EDPOP

A virtual research environment (VRE) that lets you collect, align and annotate bibliographical and biographical records from several online catalogs.
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

/api/records/?collection__id=X appears to always return all records unconditionally #135

Open jgonggrijp opened 1 year ago

jgonggrijp commented 1 year ago

I am finalizing the branch on which I implemented #118. This branch is currently based on a merger of #127 and #133; I will rebase it on develop before merging.

While testing on this branch, I noticed that there seems to be no difference between my collections. They all contain the same records, and a large number at that. At least, this is how it appears in the frontend; in the admin pages, I can see that not all of those records should be in each of the collections. However, the frontend is not at fault; it calls the correct API endpoints and accurately reflects the responses. Concluding, the problem appears to be in the API; it no longer filters records by collection.

This problem may or may not have been introduced in #127, or alternatively, may or may not have been fixed already in one of the hotfixes on master. Probably best to check whether this bug still appears after the hotfixes, #127, #133 and the upcoming final refresh pull request have been merged, and if so, fix it at that point.