search

UUDigitalHumanitieslab / EDPOP

A virtual research environment (VRE) that lets you collect, align and annotate bibliographical and biographical records from several online catalogs.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Allow choice of external database #174

Closed tijmenbaarda closed 2 months ago

tijmenbaarda commented 2 months ago

Split the submenu to choose a database into two (choose external catalog and choose collection) and show all available catalogs in the first submenu.

tijmenbaarda commented 2 months ago
  • Both the catalog dropdown and the collection dropdown change the route. This entails a semantic where the user can either pick a catalog or pick a collection, but not both at the same time. This conflicts with the presentation of two dropdowns side-by-side, which seems to suggest the choice is independent. Navigation needs an overhaul, anyway, so this is probably beyond the scope of the current pull request.

I agree that the dropdowns as they are looking now suggest two independent choices. The reason I split the two was that the list was becoming too long. But there are no plans to make it possible to search catalogues and collections side by side, as far as I know (at least this does not appear in Andrea's sketches). I propose to change the dropdowns from state setters to submenus, so that it suggests that the user is led to different pages spread across the submenus.

tijmenbaarda commented 2 months ago

Changes are done. @jgonggrijp: As for the layout change, you may want to look at my last two commits before merging, as these contain some new things.