search

UUDigitalHumanitieslab / EDPOP

A virtual research environment (VRE) that lets you collect, align and annotate bibliographical and biographical records from several online catalogs.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Add missing trailing commas to API URLs #175

Closed jgonggrijp closed 3 months ago

jgonggrijp commented 3 months ago

Without these changes, this trigger:

https://github.com/UUDigitalHumanitieslab/EDPOP/blob/1f5fe3497fc35f24c819122da0a3a6c98e61514d/frontend/vre/main.js#L112

never happens for me, and the collection dropdown is not inserted in the DOM as a result. This is because Django does not recognize the URLs without a trailing slash and defaults to the index page. The collections in question cannot read the HTML and therefore never trigger their update events, causing the finish trigger to fail.

@tijmenbaarda It is unclear to me why this does not seem to have affected you. Please check whether the application still works for you with these changes. Manually load http://localhost:8000/static/bundle.js first and refresh to make 100% sure that the browser is running the latest code.

tijmenbaarda commented 3 months ago

I have no idea why things were working on my installation, but with this branch it still works and also my code in #174 still works when merging this branch into it.