UUDigitalHumanitieslab / EDPOP

A virtual research environment (VRE) that lets you collect, align and annotate bibliographical and biographical records from several online catalogs.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Reactivity #178

Closed jgonggrijp closed 1 month ago

jgonggrijp commented 1 month ago

This branch closes #177 and also partially addresses #123, #130 and #131.

These changes demonstrate a few tricks and principles (apart from a few other, minor cleanups):

I write "demonstrate", because there is also still some code that could use the above treatment, but which I skipped. That means that #123, #130 and #131 cannot be closed yet.

You are cordially invited to read the code changes for inspiration. I expect at least some of the changes to raise questions; please do not hesitate to ask for clarification where needed.

I expect these changes to conflict with changes that you have written in parallel. I propose to merge your changes first, I will rebase my changes on yours after that.

jgonggrijp commented 1 month ago

I must admit that it took me some time to understand how this works.

No shame in that, especially given that it was already expected.

Part of that was because it is hard to find out what kind of values are expected in the various properties of the navigationState model. Is there a usual way to document what the model's properties mean?

Not that I'm aware of, but we can probably agree on something. Do you have suggestions?

I think also collection.search.view.js has to be renamed to catalog.search.view.js, but maybe it is better to do that after #183 is merged.

Agreed!

tijmenbaarda commented 1 month ago

@jgonggrijp : I have merged develop into your branch so that I can continue with the next step. The merge conflicts were not dramatic and it helped me to understand your new set-up better.

jgonggrijp commented 1 month ago

@tijmenbaarda I will rebase this branch on develop before merging, because the history will be cleaner in that way. However, it is no problem if you already based new work on this branch; you can rebase your new branch on develop again afterwards.