Unclear purpose of collection selection

UUDigitalHumanitieslab / EDPOP

A virtual research environment (VRE) that lets you collect, align and annotate bibliographical and biographical records from several online catalogs.

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Unclear purpose of collection selection #190

Open lukavdplas opened 2 months ago

lukavdplas commented 2 months ago

When you open the search menu for a catalogue, the page shows a form to select one or more collections. Screenshot:

screenshot of EDPOP, showing a search form and an input labelled "choose collections", with an "add" button

The purpose of this menu is not very clear. I initially assumed this was a search filter, but from the source code, I think it's used to add search results to collections?

Some suggestions:

Add a clearer label, e.g. "add selected records to collections" instead of "choose collections".
Hide or disable the controls when the user has not entered query yet.

tijmenbaarda commented 2 months ago

Agree, I think both suggestions should be implemented.

jgonggrijp commented 2 months ago

Hiding the control before there are search results used to work before #178. This is a regression that I consciously allowed to happen, because the functionality was implemented in a brittle, stateful manner. Shall I prepare a PR with a suggested fix?

lukavdplas commented 2 months ago

I don't think it's a priority at the moment, so unless it's a trivial change, I would suggest leaving this until we have the core functionality working.