Closed jgonggrijp closed 1 month ago
- A project must be selected before you can create a collection. If no project is selected, collection creation silently fails, but an entry with the new name still appears in the menu.
When I try this, no new entry is added to the menu but an exception project is undefined
is raised.
While frontend collection handling forms the overarching story of this branch, it is a bit of a hodgepodge of small changes:
summary
of a collection visible through a<small>
insertion in the page header.idAttribute
of the Backbone model that represents a single VRE collection touri
.<small>
in the page header in order to adjust thesummary
of a collection.OverlayView
in order to support this. It can do one thing: temporarily replace an arbitrary DOM element by an arbitrary view, based on a selector relative to a persistent root element.OverlayView
instances).idAttribute
of theProject
model toname
. It appears that theidAttribute
was never set to a correct value before this..editorconfig
..gitignore
.headlessChrome
from the default browsers in the Karma config as discussed in https://github.com/UUDigitalHumanitieslab/EDPOP/pull/200#discussion_r1740803381.GlobalVariables
, using thevreChannel
instead for loose coupling. This brings us a bit closer to #123 again.modelSlashUrl
from backbone-util.I will be on vacation soon, so I prioritized fast delivery over comprehensiveness. Hence, there are some omissions and rough edges that I am aware of:
but an entry with the new name still appears in the menu.There are also things that were already broken on
develop
and which are not fixed by this branch:For review, I suggest giving the frontend a quick spin and just scrolling through the code changes. There are lots of files with only minor changes, but I think you will be able to quickly identify repeating patterns and skip over those.