search

UUDigitalHumanitieslab / I-analyzer

The great textmining tool that obviates all others
https://ianalyzer.hum.uu.nl
MIT License
6 stars 2 forks source link

Feature/angular 17 #1529

Closed JeltevanBoheemen closed 3 weeks ago

JeltevanBoheemen commented 3 months ago

Resolves #1329

A few important notes:

lukavdplas commented 3 months ago

Reopens https://github.com/UUDigitalHumanitieslab/I-analyzer/issues/1347. Working on an Ivy distribution of the package to fix it again

That bug can cause some very annoying behaviour (if I recall correctly, it was not limited to visualisation options); since this update does not bring any direct improvements to the user, can we hold off on merging it?

Big version jump for ng2-pdf-viewer. i don't have data to test this. @lukavdplas or @BeritJanssen would you be so kind to check if the pdf viewer still works?

I don't have any PDF data locally; perhaps the test server is the easiest place to check this?

BeritJanssen commented 2 months ago

1408 depends on a newer Angular version, so I'm afraid we cannot hold this off for too long.

ar-jan commented 2 months ago

By the way, can these warnings be ignored or should they be addressed?

warning " > ng2-pdf-viewer@10.0.0" has unmet peer dependency "pdfjs-dist@~2.16.105". warning " > terser-webpack-plugin@5.3.6" has unmet peer dependency "webpack@^5.1.0".

JeltevanBoheemen commented 3 weeks ago

By the way, can these warnings be ignored or should they be addressed?

warning " > ng2-pdf-viewer@10.0.0" has unmet peer dependency "pdfjs-dist@~2.16.105". warning " > terser-webpack-plugin@5.3.6" has unmet peer dependency "webpack@^5.1.0".

I have added them to the peer dependencies in package.json. Oddly, when doing things directly in the frontend (such as updating browserslists), the warnings still occur. Anyway, safe to ignore.