UUDigitalHumanitieslab / I-analyzer

The great textmining tool that obviates all others
https://ianalyzer.hum.uu.nl
MIT License
6 stars 2 forks source link

Merge Corpus and CorpusConfiguration models? #1537

Open lukavdplas opened 2 months ago

lukavdplas commented 2 months ago

The corpus database models split a corpus into a Corpus and CorpusConfiguration. These models have a one-to-one relationship. (Corpus is the "reference" object, CorpusConfiguration contains all the settings. C.f. documentation on corpus models).

Originally, the main motivation for this separation was that when you load Python corpus definitions, you can just remove all CorpusConfiguration data and make a clean import. However, https://github.com/UUDigitalHumanitieslab/I-analyzer/pull/1515 makes the corpus import less destructive, so this isn't really needed.

I feel like this split just make things needlessly complicated, so perhaps we should merge the two models into a single Corpus model.

@JeltevanBoheemen what do you think?