UUDigitalHumanitieslab / sastadev

Method definitions for use in SASTA
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Missing dependency when installing from package? #22

Closed bbonf closed 1 year ago

bbonf commented 1 year ago

See https://github.com/UUDigitalHumanitieslab/mwe-query/actions/runs/5879266792/job/15942950883#step:6:24 about missing typing_extensions, although I do see it in sastadev's requirements.txt via mypy.

Any idea what went wrong here?

JeltevanBoheemen commented 1 year ago

The requirements.txt of sastadev aren't installed when installing the package through pip. I'll have to add them to install_requires in setup.py. Good find.

JeltevanBoheemen commented 1 year ago

Should be resolved in be712d8