search

UUPharmacometrics / xpose

Graphical diagnostics for pharmacometric models
https://uupharmacometrics.github.io/xpose
GNU Lesser General Public License v3.0
55 stars 29 forks source link

test failure with dplyr 1.0.1 #184

Closed romainfrancois closed 4 years ago

romainfrancois commented 4 years ago

We're seeing these test failures when testing xpose against dplyr 1.0.1, to be released very soon: 

==> devtools::test()

Loading xpose
Loading required package: ggplot2
Testing xpose
✓ |  OK F W S | Context
x |   7 1     | Check console output function [2.0 s]
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
test-console_outputs.R:27: error: Check prm_table returns a proper message
no applicable method for 'tbl_vars' applied to an object of class "character"
Backtrace:
  1. testthat::expect_equal(...) tests/testthat/test-console_outputs.R:27:2
 10. xpose::prm_table(xpdb_ex_pk, .problem = 1)
 14. purrr::map(...)
 15. xpose:::.f(.x[[i]], ...)
 12. dplyr::mutate_all(., .funs = "as.character")
 24. dplyr:::manip_all(...) /Users/romainfrancois/git/tidyverse/dplyr/R/colwise-mutate.R:255:2
 28. dplyr::tbl_nongroup_vars(.tbl) /Users/romainfrancois/git/tidyverse/dplyr/R/colwise-mutate.R:306:4
 30. dplyr::tbl_vars(x) /Users/romainfrancois/git/tidyverse/dplyr/R/tbl.r:74:2
 33. dplyr:::tbl_vars_dispatch(x) /Users/romainfrancois/git/tidyverse/dplyr/R/tbl.r:60:2
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✓ |  18       | Check xpdb_edits [0.8 s]
✓ |  12       | Check fetch_data [0.1 s]
✓ |  12       | Check list_nm_tables [0.2 s]
✓ |   3       | Check manual_import [0.9 s]
✓ |  63       | Check model summary functions [0.8 s]
✓ | 141       | Check plot functions [4.6 s]
✓ |   6       | Check printing method for xpose_plots [1.5 s]
✓ |   7       | Check read_nm_files [0.7 s]
✓ |   8       | Check read_nm_model [0.1 s]
✓ |  12       | Check read_nm_tables [1.2 s]
✓ |  16       | Check set_vars [0.2 s]
✓ |   6       | Check theme objects
✓ |   7       | Check update_theme
✓ |  11       | Check variable transformation calculations [1.0 s]
✓ |  32       | Check VPCs [3.4 s]
x |  43 1     | Check xpdb_access functions [2.4 s]
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
test-xpdb_access.R:165: failure: get_prm works properly
`get_prm_test_tr` not identical to `get_prm_ctrl_tr`.
Attributes: < Component "class": Lengths (2, 4) differ (string compare on first 2) >
Attributes: < Component "class": 1 string mismatch >
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✓ |  39       | Check xplot_helpers
✓ |  52       | Check default plot functions [0.2 s]
✓ |  16       | Check xpose_data [2.8 s]
✓ |   5       | Check xpose_geoms
✓ |  13       | Check xpose_save [1.6 s]

══ Results ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 24.8 s

OK:       529
Failed:   2
Warnings: 0
Skipped:  0

I haven't yet looked in details.