search

UUPharmacometrics / xpose

Graphical diagnostics for pharmacometric models
https://uupharmacometrics.github.io/xpose
GNU Lesser General Public License v3.0
55 stars 29 forks source link

NMTRAN vs NM-TRAN #200

Open rfaelens opened 2 years ago

rfaelens commented 2 years ago

In https://github.com/UUPharmacometrics/xpose/blob/3e67b397a495f92d22a4fc492fb78457b2577c75/R/read_nm_model.R#L100, the code searches for the magic string NM-TRAN MESSAGES.

Some software uses NMTRAN MESSAGES instead (note absence of the hyphen).

The package would be much more flexible if all magic strings can be put into an option. That way, I could simply execute options(xpose.magic.nmtranMessages = "NMTRAN MESSAGES"), instead of adapting the LST file manually or adapting the xpose code.

bguiastr commented 2 years ago

Thanks for the input @rfaelens. Do you expect many more variations of NMTRAN vs NM-TRAN? If not I would simply add the hyphen as optional in the regular expression.

rfaelens commented 2 years ago

I do not expect any other variations; what you propose would also work.