search

UVASOMIT / metron

JavaScript convenience library and framework written in TypeScript.
MIT License
6 stars 7 forks source link

Adding field validation error results enhancement #117

Closed TomJLynch closed 6 years ago

TomJLynch commented 6 years ago

If there is a label associated with a field causing an error and it's not an empty string use the innerText of the label in the error message

szul commented 6 years ago

@TomJLynch Version number should be 2.8.0 instead of 2.8.4--the "bug fix" version gets dropped when the minor version or major version is incremented. I've corrected this in a different edit, so you'll have to merge this back to your fork. You'll also have to edit any package.json file in your projects if you put 2.8.4 in there. Otherwise, you're good to go in the NPM registry.

TomJLynch commented 6 years ago

Duh. I should have known better about the last digit. Thanks, I'll get that shiznit updated on my side soon.

On Saturday, March 3, 2018, Michael Szul notifications@github.com wrote:

@TomJLynch https://github.com/tomjlynch Version number should be 2.8.0 instead of 2.8.4--the "bug fix" version gets dropped when the minor version or major version is incremented. I've corrected this in a different edit, so you'll have to merge this back to your fork. You'll also have to edit any package.json file in your projects if you put 2.8.4 in there. Otherwise, you're good to go in the NPM registry.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/metronical/metron/pull/117#issuecomment-370180678, or mute the thread https://github.com/notifications/unsubscribe-auth/AXLldIGzQOcafiRmNjRwj993If4EAWYRks5tawjngaJpZM4SaZIk .