UVAshley / krank

Automatically exported from code.google.com/p/krank
0 stars 0 forks source link

Misc. fixes for field.xhtml and simpleField.xhtml #35

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
There are a few c:if tags where the test attribute value is e.g. "empty
type" instead of "${empty type}", and I'm pretty sure this string literal
will evaluate to true, and so "type" will never get set.

<crank:form> passes ${crud.name} as the "entityName" value of <crank:field>
-- not ${crud.entityClass.name}.

Finally, I'd like to change the default value for disabled to be ${false}
not ${true}.  If I want to construct a form like this:

  <crank:form ...>
    <h:gridPanel ...>
      <crank:field name="field1"/>
      <crank:field name="field2"/>
      <crank:field name="field3"/>
      <crank:field name="field4"/>
    </h:gridPanel>
  </crank:form>

I don't see why I have to type instead:

  <crank:form ...>
    <h:gridPanel ...>
      <crank:field name="field1" disabled="${false}"/>
      <crank:field name="field2" disabled="${false}"/>
      <crank:field name="field3" disabled="${false}"/>
      <crank:field name="field4" disabled="${false}"/>
    </h:gridPanel>
  </crank:form>

Any explanation why a field would be disabled by default?

Original issue reported on code.google.com by james.ju...@gmail.com on 31 Jul 2008 at 4:34

Attachments:

GoogleCodeExporter commented 9 years ago
oops.  this is better:

  <crank:form ...>
    <h:panelGrid ...>
      <crank:field fieldName="field1"/>
      <crank:field fieldName="field2"/>
      <crank:field fieldName="field3"/>
      <crank:field fieldName="field4"/>
    </h:panelGrid>
  </crank:form>

Original comment by james.ju...@gmail.com on 31 Jul 2008 at 4:54