search

UVicRocketry / PDP-Monitoring-System

The Propulsion Development Platform (PDP) Monitoring System is a web-based application that allows users to monitor the status of the engine controls and instrumentation. The PDP is a testbed for the development of propulsion systems, and the monitoring system is used to control valve actuation, monitor sensor readings, and record data.
0 stars 0 forks source link

[3.6] NCV does not give feedback #10

Open klemie opened 2 months ago

klemie commented 2 months ago

Description

The NCV valve doesn't seem to send feedback. It gets suck in "in transit" even though the valve hits the limit switch. Probably a firmware problem

Acceptance Criteria

QA Notes

Linked issues

jjderooy commented 1 month ago

I read through Controls.ino and don't see any discrepancy between the way NCV is treated compared to the other valves.

Next step is to watch the serial output from the mega and confirm it is correctly reading the limit switches. I tested the switches themselves and they're both good.

@krislemie is it possible it's not a firmware problem and you're not checking for a state or something in the gui? I also remember once Hayden uploaded the code from main on the Hybrid-Controls-System repo, it acted differently so maybe this isn't actually a problem anymore.