search

UW-GAC / dbgaptools

R package to create and check standard files for dbGaP submission
Other
1 stars 3 forks source link

allow for .xls(x) DS input #13

Open sarahcn opened 6 years ago

sarahcn commented 6 years ago

Submission guide states that DS can be in either .txt or .xlsx input format - I had misread that initially and was only allowing for .txt input maybe it's possible to have just one 'read' function that has an argument for dd=TRUE or dd=FALSE (where dd=FALSE means it's read in as a DS file)

broomej commented 4 years ago

I'm assuming this is about read_ds_file() and read_dd_file(). Do changes need to be made elsewhere?

broomej commented 4 years ago

I just noticed that dd = TRUE is an argument for read_ds_file(). Do we want to use read_ds_file() to read datasets and data dictionaries, and depricate read_dd_files?

The alternative I can think of is to leave both functions, but have them as a wrapper for more flexible function (maybe exported, maybe not, I'm not sure) that takes the dd argument. This seems maybe a little more convoluted than necessary

smgogarten commented 4 years ago

read_dd_file calls read_ds_file(dd=TRUE), so read_ds_file is already the base function.