UW-Hydro / MetSim

Meteorology Simulator
http://metsim.readthedocs.io/
GNU General Public License v3.0
61 stars 50 forks source link

Fixed Disaggregate.py for Passthrough of Daily Mean Shortwave Calculated from Entire Day #256

Closed benb0228 closed 11 months ago

benb0228 commented 1 year ago

I made more commits then needed (first time updating code)...so you may want to just add the code that I've updated in the commit...Notice, the if/else statements are the same - crucial to allow for daily mean shortwave to be disaggregated correctly using passthrough, so those lines of code could be shortened.

https://github.com/UW-Hydro/MetSim/commit/2560937baf1c2d9dec665c0827c799efe5dc4a1a

This fix allows for daily mean shortwave computed from entire day (86400.0 seconds) to be used as input for passthrough and result in correct output...Current master of MetSim does not computes larger than realistic fluctuations in hourly shortwave for such a case.