UW-Hydro / MetSim

Meteorology Simulator
http://metsim.readthedocs.io/
GNU General Public License v3.0
62 stars 50 forks source link

Add references for longwave & cloud calculations #69

Closed arbennett closed 7 years ago

jhamman commented 7 years ago

@arbennett - I think @tbohn will be a good reference for getting this done.

bartnijssen commented 7 years ago

@tbohn : Can you let @arbennett know which references we need to include in the MetSim documentation for the longwave and cloud calculations?

@arbennett : Can you be specific with @tbohn what you are looking for?

arbennett commented 7 years ago

@tbohn What I want to reference are the entries in cloud_calc and emmisivity_calc within the metsim/disaggregate.py module link.

I think it's hinted at the sources in the VIC code, but I haven't dug into it too much.

tbohn commented 7 years ago

Sure, the citations are as follows. To get the full bibliographic information, look up the citations in Bohn et al. (2013), whose bib info is at the bottom of this comment. The part of Bohn et al (2013) that talks about these various methods is Appendix A.

emissivity_calc:

cloud_calc:

Bohn, T.J., Livneh, B., Oyler, J.W., Running, S.W., Nijssen, B. and Lettenmaier, D.P., 2013. Global evaluation of MTCLIM and related algorithms for forcing of ecological and hydrological models. Agricultural and forest meteorology, 176, pp.38-49.

arbennett commented 7 years ago

@tbohn This is great, thank you!

A couple things:

  1. I think I took the initial implementation of these from @jhamman's initial mock up of a standalone MTCLIM.
  2. The default emissivity is actually set to prata
  3. The default cloud is set to deardorff

It's probably worth updating these names, as you've said. At the point this part was being implemented I didn't really understand anything about MTCLIM (or even hydrology for that matter...).

tbohn commented 7 years ago

Ah, ok. I should have looked more closely at the code to see what the actual defaults were. Thanks for updating the names (and removing the DEFAULT emissivity option altogether as it doesn't really make physical sense).

bartnijssen commented 7 years ago

Closed per PR #91