search

UW-Hydro / RBM

River Basin Model - Stream temperature modeling
GNU General Public License v2.0
7 stars 6 forks source link

Develop #9

Closed jyearsley closed 7 years ago

jyearsley commented 8 years ago

Added Water Balance routine to account for local inflow changes and potential for hyporheic flow.

Simplified Particle_Track routine

Simplified interpolation scheme to perform linear interpolation at upstream and downstream boundaries. Corrected definition of interpolated points to include both the upstream and downstream points in the interpolation

bartnijssen commented 8 years ago

Let me know if this is ready to merge and I will go ahead and merge it (i.e. I assume this already went through review)

jyearsley commented 8 years ago

Thanks, Bart, If you mean by review, have I posted it on the Slack github channel, the answer would be, "no". I will do so, however. I can copy the URL to the Slack channel, or, is there a more Slack-like way?

John

John Yearsley Affiliate Professor UW-Hydro|Computational Hydrology University of Washington

jyearsle@uw.edu uw-hydro.github.io/current_member/john_yearsley

On Thu, Sep 22, 2016 at 1:26 PM, Bart Nijssen notifications@github.com wrote:

Let me know if this is ready to merge and I will go ahead and merge it (i.e. I assume this already went through review)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UW-Hydro/RBM/pull/9#issuecomment-249018128, or mute the thread https://github.com/notifications/unsubscribe-auth/AKrr_Zn0oNzFeGhYVBkadOkYXtuQjeXpks5qsuSSgaJpZM4J_Jet .

bartnijssen commented 7 years ago

@YifanCheng : Since you are the maintainer of this repo, the PRs should be removed by you in a timely manner. This PR is 3 months old!