nickrsan
commented
5 years ago Hi all,
I realized that I may have been conflating two development teams with this patch. I'm assisting a team working with this model (https://www.sciencebase.gov/catalog/item/5b170442e4b092d9651fcc93) that uses RVIC. Their workflow downloads climate data from a UC Berkeley server - that server's data has no calendar attribute for the Time variable in the NetCDF files - in our case, using the default calendar seemed sensible, but if that's not sensible for RVIC core, then feel free to reject this - I also wasn't sure if adding mm/day under mm for units was appropriate, but it made sense for our case. Hope that helps provide some context
Downloaded runoff (and other) data are now missing the "calendar" attribute for the time variable. This fix uses the default calendar specified in the config file if that's missing and emits a warning.
Also adds mm/day as an acceptable unit. Both were causing crashes in current use.