Clean up surface_fluxes.c

[tbohn]

Currently the logic accounting for a) iteration between surface and canopy temperature solutions, b) snow step vs model step, and c) distributed precip results in a confusing mess of data structures and loops. This makes adding features and preventing bugs more difficult than otherwise.

[bartnijssen]

This will partially be cleaned by removing the DIST_PREC option (Issue #22). Any further cleanup will have to wait.

[jhamman]

@tbohn - now that we've removed the DIST_PREC code and gone ahead with the other cleanup tasks (#162), do you think there is anything else to do here? If this will be part of the 5.0 release, we need to come up with a path forward for how to clean up surface_fluxes.c.

[tbohn]

I'll need some time to think about this... Can we discuss later this week?

On Sun, Dec 7, 2014 at 5:08 PM, Joe Hamman notifications@github.com wrote:

@tbohn https://github.com/tbohn - now that we've removed the DIST_PREC code and gone ahead with the other cleanup tasks (#162 https://github.com/UW-Hydro/VIC/issues/162), do you think there is anything else to do here? If this will be part of the 5.0 release, we need to come up with a path forward for how to clean up surface_fluxes.c.

— Reply to this email directly or view it on GitHub https://github.com/UW-Hydro/VIC/issues/31#issuecomment-65964946.

[jhamman]

@bartnijssen and @tbohn - is something that we think is going to happen for 5.0? It has been idle for 8 months or so now?

[bartnijssen]

@jhamman : I am going to move this to "someday". Any change in the iteration sequence is likely to change the answer, something that we don't want as part of 5.0. I'll leave it to @tbohn to take a look and see what change he thinks would be worthwhile for a later milestone