search

UW-Hydro / VIC

The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model
http://vic.readthedocs.io
MIT License
262 stars 392 forks source link

Understimation of incoming longwave radiation when forcing the model with downscaled shortwave radiation #52

Closed homefc closed 11 years ago

homefc commented 11 years ago

When downscaled daily downward shortwave radiation is used as an input to the model, for some reason incoming longwave is calculated assuming clear skies always, and this results in an underestimate of incoming longwave on cloudy days. The error is likely linked to the estimate of the clear sky fraction in MTCLIM.

bartnijssen commented 11 years ago

OK - let's make sure that this gets tested and makes it in the new bug fix update (hot fix) as soon as possible. This will affect a number of ongoing projects and is important to get right.

Homero: Please suggest a fix and test it.

I have assigned Ted to do the actual merge, since he has mostly dealt with the forcing side of the business.

tbohn commented 11 years ago

Yes, Homero mentioned this to me, and I am going to look into it soon.

On Wed, Sep 11, 2013 at 4:28 PM, bartnijssen notifications@github.comwrote:

OK - let's make sure that this gets tested and makes it in the new bug fix update (hot fix) as soon as possible. This will affect a number of ongoing projects and is important to get right.

Please suggest a fix and test it. I have assigned Ted, since he has mostly dealt with the forcing side of the business.

— Reply to this email directly or view it on GitHubhttps://github.com/UW-Hydro/VIC/issues/52#issuecomment-24284496 .

homefc commented 11 years ago

Bart, Ted, I think I've found the fix and will send a pull request after I have tested it, so that Ted can merge it.