search

UW-Hydro / VIC

The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model
http://vic.readthedocs.io
MIT License
259 stars 385 forks source link

Some codes might can be further normalized? #809

Closed Sibada closed 6 years ago

Sibada commented 6 years ago

Bug Reports

My R package for the VIC model has been completed and I try to release it to CRAN. However there is still one WARNING in the R CMD Check (the R packages with ERROR or WARNING would not pass):

* checking whether package 'VICmodel' can be installed ... WARNING
Found the following significant warnings:
  vic/vic_run/src/CalcBlowingSnow.c:308:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/vic_run/src/CalcBlowingSnow.c:487:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/drivers/shared_all/src/input_tools.c:44:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/drivers/shared_all/src/input_tools.c:135:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/drivers/shared_all/src/input_tools.c:169:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/drivers/shared_all/src/input_tools.c:224:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/drivers/shared_all/src/input_tools.c:276:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/drivers/shared_all/src/input_tools.c:300:1: warning: control reaches end of non-void function [-Wreturn-type]
  vic/drivers/shared_all/src/print_library_shared.c:51:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:71:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:158:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:159:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:260:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:261:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:263:13: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:268:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:269:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:271:17: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:273:17: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:274:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:276:17: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:278:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:299:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:476:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:477:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:478:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:479:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:480:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:483:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:485:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:493:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:524:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:541:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:567:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:568:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:579:17: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:582:13: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:618:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:622:9: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:648:17: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:651:13: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:1147:5: warning: too many arguments for format [-Wformat-extra-args]
  vic/drivers/shared_all/src/print_library_shared.c:1206:5: warning: too many arguments for format [-Wformat-extra-args]

If it is proper and useful I could help to revised those problems.

And the source code of the R package have been upload to GitHub (https://github.com/Sibada/VICmodel) and welcome to try and comment.

jhamman commented 6 years ago

@Sibada - a pull request fixing any of these warnings would be appreciated.