Fixes for fcanopy/LAI/esoil logic

UW-Hydro / VIC

The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model

http://vic.readthedocs.io

MIT License

262 stars 393 forks source link

Fixes for fcanopy/LAI/esoil logic #823

Closed tbohn closed 6 years ago

tbohn commented 6 years ago

[x] closes #821
[ ] tests passed
[ ] new tests added
[ ] science test figures
[ ] ran uncrustify prior to final commit
[ ] ReleaseNotes entry

dgergel commented 6 years ago

@tbohn thanks for putting this together. I have tested this on a pure bare soil gridcell in the RASM domain and the behavior is what we want, e.g. this fixes the issue we were seeing before with no bare soil evaporation except during times of snow for pure bare soil gridcells.

@bartnijssen and @jhamman, would either of you also like to do a review?