search

UW-Hydro / VIC

The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model
http://vic.readthedocs.io
MIT License
259 stars 385 forks source link

Support/vic.4.2.glacier #891

Closed anewman89 closed 5 years ago

anewman89 commented 5 years ago

This fixes issue #890. The test case that was crashing on UW machine h2o, NCAR Cheyenne, and NCAR hydro-c1 now runs to completion on hydro-c1 with no negative bot_band values.

The fix simply ignores the time scaling when ice_area_new is negative and sets ice_area_new = ice_area_old. Because this is within the positive ice_vol if statement (line 81), ice_area_old is > 0 and the while statement on line 107 will be executed at least once moving bot_band to zero or larger.

This fix should probably still be tested on h2o and Cheyenne? I can test on Cheyenne.

anewman89 commented 5 years ago

I rechecked for negative bot_band and found none in the test case on hydro-c1.