cffi headers: respect $CC if defined - Githubissues

UW-Hydro / VIC

The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model

http://vic.readthedocs.io

MIT License

259 stars 385 forks source link

cffi headers: respect $CC if defined #894

Closed minrk closed 4 years ago

minrk commented 4 years ago

default behavior is unchanged, but fixes builds on e.g. conda where compilers have funky names (https://github.com/conda-forge/vic-feedstock/pull/4) or gcc is not what should be used.

[ ] closes #xxx
[ ] tests passed
[ ] new tests added
[ ] science test figures
[ ] ran uncrustify prior to final commit
[ ] ReleaseNotes entry

I ran uncrustify but didn't commit the changes because it changed a bunch of C files that aren't related to this PR. There isn't a release notes section for the next unreleased version, so I didn't feel ready to start one with such a minor fix.

jhamman commented 4 years ago

Thanks @minrk - I'll take it from here. I'm really impressed by your persistence on this one. I'm guessing you aren't a user of the VIC model? Your efforts on conda-forge (and beyond) are much appreciated.

minrk commented 4 years ago

I'm guessing you aren't a user of the VIC model?

I'm not, this is with my conda-forge mpi maintainer hat on. I'm learning how to build and install lots of tools I don't use!