Fix for 4-d variable output in standard memory mode

UW-Hydro / tonic

A pre/post processing toolbox for hydrologic models

MIT License

20 stars 34 forks source link

Fix for 4-d variable output in standard memory mode #25

Closed anewman89 closed 8 years ago

anewman89 commented 8 years ago

Issuing pull request for potential bug fix in 4-d variable output for standard memory mode.

landscape-bot commented 8 years ago

Repository health decreased by 0.47% when pulling 72dc18a on anewman89:develop into 52b3f9d on UW-Hydro:develop.

8 new problems were found (including 0 errors and 0 code smells).
No problems were fixed.

jhamman commented 8 years ago

fixes #24

jhamman commented 8 years ago

I'll have to look at this a bit more. I don't love either implementation so I'll need to think on it. I gave you some comments to get you started cleaning it up a bit though. Thanks.

landscape-bot commented 8 years ago

Repository health decreased by 18% when pulling 238902d on anewman89:develop into 52b3f9d on UW-Hydro:develop.

2 new problems were found (including 2 errors and 0 code smells).
27 problems were fixed (including 0 errors and 16 code smells).

landscape-bot commented 8 years ago

Repository health decreased by 0.43% when pulling 04c8278 on anewman89:develop into 52b3f9d on UW-Hydro:develop.

8 new problems were found (including 0 errors and 0 code smells).
No problems were fixed.

bartnijssen commented 8 years ago

@anewman89 : Just ran across this - is this still an active PR?

anewman89 commented 8 years ago

I never got anywhere further with this. In fact, my fix is likely buggy as I got some large disk I/O issues when I ran it on Yellowstone at NCAR. So lets close this specific request without a merge, I can make the original reason for the pull request an issue.

bartnijssen commented 8 years ago

Agreed - open an issue and then close this PR