search

UW-Hydro / tonic

A pre/post processing toolbox for hydrologic models
MIT License
20 stars 34 forks source link

Added support for lake, blowing snow, and flexible lai/fcanopy/albedo to grid_params.py #40

Closed tbohn closed 8 years ago

tbohn commented 8 years ago

Modified grid_params.py to account for:

  1. optional extra columns in soil_param file
  2. optional extra fcanopy in veg_lib file
  3. optional blowing_snow params in veg_param file
  4. optional lai, fcanopy, albedo in veg_param file
  5. optional lake_param file
  6. reading of veg_lib comment field
  7. conditional creation of bare soil class, only if not already present

This closes #38. This does not completely address issues #29, #31, and #34. It addresses converting these from ascii to netcdf, but not netcdf to ascii.

jhamman commented 8 years ago

Lot's of little comments @tbohn - Thanks for pulling this together. Give me a ping once you've had a chance to go through them.

tbohn commented 8 years ago

OK, pushed and built.

tbohn commented 8 years ago

Hold on a sec, I accidentally committed a "print" statement that I had inserted for debugging purposes.

jhamman commented 8 years ago

Okay, let me know when its ready for review/merge.

tbohn commented 8 years ago

OK, this is ready for merge. I perused the Landscape code quality report for the first time - very interesting.