UW-Hydro / tonic

A pre/post processing toolbox for hydrologic models
MIT License
20 stars 33 forks source link

snow17.py (commit #55) generates non-zero outflow in absence of precip and snowmelt #69

Open rtroper0 opened 6 years ago

rtroper0 commented 6 years ago

snow17.py generate a non-zero outflow even when there is no precip or snowmelt. In the screenshot below, cumulative outflow (after all snow has melted) exceeds cumulative precip:

image

I noticed that when I comment out the w_q term in line 234 (see screenshot below), I no longer see the discrepancy between cumulative outflow and cumulative precip.

image

Here's a plot of the results after commenting out w_q in line 234:

image

Commenting out w_q in line 234 appears to have resolved the issue in this particular case, but I don't know if it's a sound solution. Somewhere in the code, it seems there must be an implementation error, because the unedited snow17.py code generates a non-zero outflow in the absence of precip and snowmelt.

ShihengDuan commented 2 years ago

Is there any update? Thx