search

UW-Macrostrat / macrostrat-api

The API for SCIENCE
3 stars 1 forks source link

querying metasedimentary and sedimentary #141

Open jonhusson opened 8 years ago

jonhusson commented 8 years ago

So the metased query has 734 unit_ids that are in the sed query and 445 that are not:

sed = webread('https://macrostrat.org/api/units?lith_class=sedimentary&format=csv&project_id=1',options);

metased = webread('https://macrostrat.org/api/units?lith_type=metasedimentary&format=csv&project_id=1',options);

cambro commented 8 years ago

so what is the problem? Some units have both metased and sed, and some units have only metased.

quartzite > metasedimentary > metamorphic sandstone > siliciclastic > sedimentary

Perhaps there should be a redefinition of lith_type and lith_class, but what you describe is currently expected. If you want all sediments lith_class=sedimentary + lit_type=metasedimentary. Or is this not the issue?

jonhusson commented 8 years ago

No problem necessarily. It was based on a question I had for John about whether there was a capability to construct a query ?lith_class=sedimentary&lith_type=metasedimentary to get sediments + metasediments. We were wondering whether the lith_class=sedimentary already does this.

On Feb 26, 2016, at 12:12 PM, Shanan Peters notifications@github.com<mailto:notifications@github.com> wrote:

so what is the problem? Some units have both meta and sed, some units have only meta. Or is this not the issue?

— Reply to this email directly or view it on GitHubhttps://github.com/UW-Macrostrat/macrostrat-api/issues/141#issuecomment-189404237.

cambro commented 8 years ago

I think this is a legitimate open question. Metasedimentary is by definition both. I think maintaining its distinct entry and requiring both to be specified when all are desired is best behavior.