search

UW-Macrostrat / macrostrat-api

The API for SCIENCE
3 stars 1 forks source link

v1 lith descriptions are not the same as v2 lith descriptions #144

Open jonhusson opened 8 years ago

jonhusson commented 8 years ago

An example set. It appears that the v1 response is missing liths found in the v2 response (i.e. the fractions do not add to 1 in v1)

https://macrostrat.org/api/v1/units?id=113,148,302,323,383,463,559,625,766,923,929,1917,2673,2724,2760,2819,3534,5400,5679,6219,7592,7870,7871,7885,7901,7908,7911,7914,8160,8162,8280,8281,8286,8404,8454,8499,8546,8732,8814,8823,8825,9057,9094,11551,11723,11777,12905,12931,12952,13011,14320,14538,15275,15387,21958,22755,34807&response=long

https://macrostrat.org/api/units?unit_id=113,148,302,323,383,463,559,625,766,923,929,1917,2673,2724,2760,2819,3534,5400,5679,6219,7592,7870,7871,7885,7901,7908,7911,7914,8160,8162,8280,8281,8286,8404,8454,8499,8546,8732,8814,8823,8825,9057,9094,11551,11723,11777,12905,12931,12952,13011,14320,14538,15275,15387,21958,22755,34807&response=long

cambro commented 8 years ago

This bug appeared when JJ rewrote my build script for the v1 lookup table used for the route. I believe I fixed this with https://github.com/UW-Macrostrat/macrostrat-api/commit/3945c1c939f93e4a518262c8dc12ae6ff2556f03 change and build has not yet been pulled down and run as of this post.

jczaplew commented 8 years ago

I now get a 'DUPLICATE KEY' error when I run v1/utilities/scripts/build_lookup_unit_liths.py

cambro commented 8 years ago

damn it... i'll look into it.

On Mon, Mar 14, 2016 at 12:38 PM, John J Czaplewski < notifications@github.com> wrote:

I now get a 'DUPLICATE KEY' error when I run v1/utilities/scripts/build_lookup_unit_liths.py

— Reply to this email directly or view it on GitHub https://github.com/UW-Macrostrat/macrostrat-api/issues/144#issuecomment-196427860 .