search

UW-Macrostrat / macrostrat-api

The API for SCIENCE
3 stars 1 forks source link

non-active columns being returned from /defs/columns route #193

Closed jonhusson closed 6 years ago

jonhusson commented 7 years ago

example: https://dev.macrostrat.org/api/v2/defs/columns?project_id=1

returns columns with both 'obsolete' and 'in process' statuses

cambro commented 7 years ago

I believe that this is expected and desirable behavior. This is the defs routes for columns and there would otherwise be no way to access this information. We could add a filter option for status.

jonhusson commented 7 years ago

That would certainly be helpful. I use this defs route to define my ‘denominator’ for normalizing package time series. Now, that code is not correct On Jun 23, 2017, at 11:37 AM, Shanan Peters notifications@github.com<mailto:notifications@github.com> wrote:

I believe that this is expected and desirable behavior. This is the defs routes for columns and there would otherwise be no way to access this information. We could add a filter option for status.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UW-Macrostrat/macrostrat-api/issues/193#issuecomment-310714072, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIZBvhGckysA58iCczdZfaQ8m_T88nVGks5sG-nEgaJpZM4ODxqd.

cambro commented 7 years ago

Ah, better to use the columns route for this purpose. That should only return active

jonhusson commented 7 years ago

I’m a dumbass! Thats’s what I actually use. Some Friday confusion…

On Jun 23, 2017, at 11:48 AM, Shanan Peters notifications@github.com<mailto:notifications@github.com> wrote:

Ah, better to use the columns route for this purpose. That should only return active

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UW-Macrostrat/macrostrat-api/issues/193#issuecomment-310716729, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIZBvrv-par90fN5liGRNIDsVnkr3-mEks5sG-xtgaJpZM4ODxqd.