C47 export to csv - Githubissues

UWA-CITS3200-18-2021 / ReSQ

ReSQ (Realtime Studysmarter Queue)

Creative Commons Zero v1.0 Universal

1 stars 0 forks source link

C47 export to csv #71

Closed TheOneHoff closed 3 years ago

TheOneHoff commented 3 years ago

Change Summary

Added a new page 'export data'
Users can select dates from a calendar
A csv is generated and download from this page

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[x] The pull request title has an issue number
[x] The code works by "Smoke testing" (in other words, you have tested it your own and it works)
[x] The code has documentation (either comments or in main documentation platform)

Other Information

Don't know if this is the right place, but its might be worth it to note that in order to add a new page to the nav bar, the code has to be copied into all the previous pages. Consider refactoring this so that the nav bar is decided in the base.html

frinzekt commented 3 years ago

Can I ask why this was deleted. This was something the client said was a priority for him.

which one?

TheOneHoff commented 3 years ago

Can I ask why this was deleted. This was something the client said was a priority for him.

I just deleted it because it was not relevant to this issue. It was basically just copied and pasted templates that didn't actually do anything. They can easily be recreated in the correct branch for the data analytics issue

JordanHartley commented 3 years ago

But won't explicitly deleting it in this delete in main when merging? If not relevant to this issue why not just leave it? Or am I mistaken of how git works im not 100% sure.

TheOneHoff commented 3 years ago

The files are not in main currently, I kind of added them to my PR by mistake. Sure I could leave it in, I just thought it'd be better to leave a clean slate for whoever works on the data analytics stuff

JordanHartley commented 3 years ago

Data.html was added a while ago, it is needed in main.

TheOneHoff commented 3 years ago

Data.html was added a while ago, it is needed in main.

I see the issue now. Thanks for picking that up. Reverted the changes now