UWB-Biocomputing / Graphitti

A project to facilitate construction of high-performance simulations of graph-structured systems.
https://uwb-biocomputing.github.io/Graphitti/
Apache License 2.0
7 stars 14 forks source link

Neuron max firing rate limit can break non-ConnGrowth simulations #52

Open stiber opened 4 years ago

stiber commented 4 years ago

Neuron max firing rate is necessary for ConnGrowth, for scaling neuron firing rates, mostly to ensure that firing rates, used to compute outgrowth, don't exceed a maximum and break the outgrowth formula. However, if we switch to, say, ConnStatic, then neurons can exceed this limit without any problem (because spiking rate isn't used for any connection computation).

So, we can just up the max rate for those simulations and leave the line of code below alone. However, perhaps it would be better to set things up so that, if we set the max rate parameter to zero, then the check below just isn't done.

https://github.com/UWB-Biocomputing/BrainGrid/blob/c6c95eb63655ae73b32cd784f3853fd73bc3c9e9/Neurons/AllSpikingNeurons.cpp#L114

fumik commented 4 years ago

Maximum firing rate used for computing outgrowth is stored in m_growth.maxRate which is set at ConnGrowth::readParameters().

The maximum firing rate in sim_info->maxFiringRate is used to allocate spiking buffer for recording .

2020/04/09 12:03、Michael Stiber notifications@github.comのメール:

Neuron max firing rate is necessary for ConnGrowth, for scaling neuron firing rates, mostly to ensure that firing rates, used to compute outgrowth, don't exceed a maximum and break the outgrowth formula. However, if we switch to, say, ConnStatic, then neurons can exceed this limit without any problem (because spiking rate isn't used for any connection computation).

So, we can just up the max rate for those simulations and leave the line of code below alone. However, perhaps it would be better to set things up so that, if we set the max rate parameter to zero, then the check below just isn't done.

https://github.com/UWB-Biocomputing/BrainGrid/blob/c6c95eb63655ae73b32cd784f3853fd73bc3c9e9/Neurons/AllSpikingNeurons.cpp#L114 https://github.com/UWB-Biocomputing/BrainGrid/blob/c6c95eb63655ae73b32cd784f3853fd73bc3c9e9/Neurons/AllSpikingNeurons.cpp#L114 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/UWB-Biocomputing/BrainGrid/issues/284, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAIFSQ6U7U7MYY4QRB4CVLRLYLY3ANCNFSM4ME6QRQQ.