UWB-Biocomputing / WorkBench

Software and data provenance management platform for simulations of dissociated cortical cultures.
https://uwb-biocomputing.github.io/WorkBench/
Apache License 2.0
1 stars 3 forks source link

Application does not terminate by closing window #15

Closed jConquest closed 3 years ago

jConquest commented 4 years ago

While the old version of WB succesfully terminates the application by closing the app's window, the new version of WB fails to do so, requiring user to use ctrl+c in the terminal corresponding to the app to fully terminate the application

jConquest commented 4 years ago

This occurs when using the Simulation Starter

jConquest commented 4 years ago

This may be related to the Analyze button issues. This will likely be addressed with the sim starter wizard.

stevecl5 commented 3 years ago

fixed in PR #84

stevecl5 commented 3 years ago

Adding info for future reference:

This appears to be caused by GUI threads (most likely from Java Swing components) that are not closed when the main display is closed. Resolved by calling Platform.exit() to close any JavaFX components and then System.exit(0) to ensure the JVM is terminated (i.e. close any remaining threads). If Java Swing components are removed in the future, this may become unnecessary.