search

UWB-Biocomputing / WorkBench

Software and data provenance management platform for simulations of dissociated cortical cultures.
https://uwb-biocomputing.github.io/WorkBench/
Apache License 2.0
1 stars 3 forks source link

Fix null pointer caused by Init when getting filestream of param templates #41

Closed jConquest closed 4 years ago

jConquest commented 4 years ago

Found the issues out. Wrong java call and a missing '/"

However, fixing this bug found a new one as well as a design question.

Issue: layoutParams tab of simulator configuration window now incomplete, missing probed list. The error should have to do with the copying of files. If I manually replace the template files while the wb is running, the problem is resolved. Every time at start-up, however, the files are copied over again and the issue is repeated.

jConquest commented 4 years ago

I confirmed that it has to do with the copying of the template files (located in main/resources/init)

Particularly, it is the FixedLayout file being copied that is stale (from previous version using different probed naming convention)

jConquest commented 4 years ago

Found that there is FixedLayout in the /test/resources /main/resources/ and /target/class/init/

tried to replace all of these, still had error. Might need to double check this.

jConquest commented 4 years ago

double checked if replacing all files copies with correct version fixes problem, it does not. It could be taking the olderWB version but that seems unlikely

jConquest commented 4 years ago

At the end of the day, Init is adding BasemTemplates and ParamsClassTemplateConfig into the target folder for execution. We have already updated the design to include the target folder with all these template files ready to go so as to make the installation process of WB faster and easier for users. Init could be removed.

jConquest commented 4 years ago

Tested WB without using Init code, everything runs perfectly. Furthermore runtime start-up has increased as there are no file copying going on

jConquest commented 4 years ago

fixed problem by finding all stale versions of layout params. With testing kit being run, this code is now necessary for first start up. No longer need the target file in dir, will be created at start up. This is now working.