UWB-Biocomputing / WorkBench

Software and data provenance management platform for simulations of dissociated cortical cultures.
https://uwb-biocomputing.github.io/WorkBench/
Apache License 2.0
1 stars 3 forks source link

NLEdit pattern generation needs reworking #49

Closed jConquest closed 3 years ago

jConquest commented 4 years ago

should keep it associated with pattern generation, but clearly not with grid re-sizing

jConquest commented 4 years ago

Repeat and alternate need investigation both in their response to user interaction and the code being called

stiber commented 4 years ago

Probably needs improved input validation. Remember that the two text fields are independent of the two radio buttons, and are applicable regardless of which radio button is selected. Each decimal should be <= 1, and their sum should be <= 1.

karthikvetrivel commented 4 years ago

Working on this right now. I'll attempt to fix some of the CSS issues as well.

EDIT: I also found out that programmatically overlapping neurons are yellow.

karthikvetrivel commented 4 years ago

Update: I've fixed some CSS issues that make the Arrange Probes and Generate Pattern tabs easier to understand. I found the pattern generation code, but honestly, It is quite complex and I'll need more time to debug it.

jConquest commented 4 years ago
jConquest commented 4 years ago

By completing the two tasks above to add clarity to NLEdit pattern generation functionality to users; this issue can be resolved per our discussion from last weeks meeting.

karthikvetrivel commented 4 years ago

By completing the two tasks above to add clarity to NLEdit pattern generation functionality to users; this issue can be resolved per our discussion from last weeks meeting.

My bad Joe, I just saw this. Does NLEdit currently have any documentation written on it? I couldn't find it. I can fix the layout on the bottom now though.

karthikvetrivel commented 4 years ago
Screen Shot 2020-08-18 at 10 24 01 PM

I kept the labels close to the TextFields intentionally to keep things clear.

jConquest commented 4 years ago

@karthikvetrivel that looks great! Much better legibility for the tool bar. There is not any documentation as of yet

jConquest commented 4 years ago

Resizing continues to have issues with ratio not matching number of added inhibitory or active neurons. The layout may also not fully maximize the distance between like and unlike neurons.

karthikvetrivel commented 4 years ago

I wrote a little more on* this, where should I put it?

jConquest commented 4 years ago

Great @karthikvetrivel we will add that to the "Running Simulations" documentation which is the docs directory in the repo. It can go just before or after the section talking about importing layout files. We will also need to import a photo or two to illustrate what we are talking about. Keep in mind that the current documentation in "Running Simulations" will be updated with the completion of the simulation wizard. We can see this addition to the documentation as the first step in this.