UWB-Biocomputing / WorkBench

Software and data provenance management platform for simulations of dissociated cortical cultures.
https://uwb-biocomputing.github.io/WorkBench/
Apache License 2.0
1 stars 3 forks source link

NLEdit resizing has issues #50

Closed jConquest closed 4 years ago

jConquest commented 4 years ago

scaling method does not make sense, or needs more clarity

stiber commented 4 years ago

The goal is that someone who wants to create a large simulation can define a pattern of neuron types and probed neurons for a small grid, and then resize/repeat it N by M times to make a much larger grid of neurons.

karthikvetrivel commented 4 years ago

I've been looking into it, and the resizing works pretty well. For example, a 5x5 with a certain pattern repeats well (4 times, as it should) when scaled to 10x10. The resizing is only questionable when the factors to scale by don't match up properly. Am I missing something?

Is this something we should catch in the user input if it doesn't scale properly?

jConquest commented 4 years ago

Yellow is caused when neurons set up to be multiple things

jConquest commented 4 years ago

This does not make sense to have an excited and inhibited neuron set as the same, hence we should most likely prevent this from occuring

jConquest commented 4 years ago

Please disregard the two previous, it is okay for them to be inhibitory and active

karthikvetrivel commented 4 years ago

Is this good to close? I don't think we found any issue with this earlier

jConquest commented 4 years ago

We can close this issue, and I will add an action item to the other NLEdit card to include a description of resizing in the documentation to be added