File management and UI fixes

UWB-Biocomputing / WorkBench

Software and data provenance management platform for simulations of dissociated cortical cultures.

https://uwb-biocomputing.github.io/WorkBench/

Apache License 2.0

1 stars 3 forks source link

File management and UI fixes #84

Closed stevecl5 closed 3 years ago

stevecl5 commented 3 years ago

This branch fixes a bug that prevented Workbench from running local simulations (Issue #83). It also resolves an issue where CSS resources could not be found if the Workbench JAR was moved to a different directory.

Additionally, it improves the functionality of the Simulation Specification dialog:

better input validation for hostname and simulation folder
improved messaging for invalid input
Run and Test Connection buttons are now only enabled when valid input is present

stevecl5 commented 3 years ago

Added:

fixes issue #15
cleanup of variable names and event handlers

stiber commented 3 years ago

This looks good to me overall. I admit I don't have a deep command of the code these days. I can approve, or @king-shak can concur; just let me know.

stevecl5 commented 3 years ago

@stiber I know that @king-shak has already done some testing on this branch, and we will be going over it together later today. If we are both happy with everything, I would like to do the merge on Wednesday after our weekly meeting so that the main branch is up to date with the latest fixes and features.

stevecl5 commented 3 years ago

Added:

updated all* occurrences of "state output" and "history dump" to "result file" for consistency with Graphitti
updated result file name from prepending historyDump_ to appending -out for consistency with Graphitti

* The XML tag in the simulation config file is still named stateOutputFileName for now since this is required in order to run BrainGrid. At some point, this will need to be changed to resultFileName in order to work with Graphitti.