search

UWB-Biocomputing / WorkBench

Software and data provenance management platform for simulations of dissociated cortical cultures.
https://uwb-biocomputing.github.io/WorkBench/
Apache License 2.0
1 stars 3 forks source link

ProVis Fixes #91

Closed king-shak closed 3 years ago

king-shak commented 3 years ago

This branch fixes a bug where Workbench would cause high CPU utilization when the application is minimized with a ProVis tab open.

resolves #86.

king-shak commented 3 years ago

Made some small changes to comply with check style requirements and to match the style of the rest of the code.

king-shak commented 3 years ago

I'll wait and see if there are any additional comments from Professor Stiber on the issue, there may be some changes which I may throw into this branch.

stiber commented 3 years ago

This looks great to me. The only argument against it would be if there is a more general "fix" for which this is merely a special case, but I don't think that's the case. But, I will ask it: how does this differ from someone resizing the window? If someone makes the window small (or if the graph is large) so that only a portion of a graph is visible, will there still be high CPU utilization? Or is that not too relevant, and the way to handle any such issues relates more to a conversation about halting graph elements migrating around one they "settle down"?