Closed JoshHeng closed 1 year ago
All good points, fixed most, will put 2 & 6 on the todo sometime: 3: I set Zola to do it automatically for markdown forgetting it didn't apply to the rest of the templates (done manually now) 7: I do want to redo the footer a little tbh, it was straight copied from the progcomp site and hardly changed from that 10: Not sure why the pubilcity icon failed to load for you, works fine every time i've tested it 13: Probably, but the spacing is already quite particular around there, so i don't particularly want to play with it
Nice work on the website! This is just personal feedback, feel free to take it or ignore it as you see fit. I can also contribute if you need help.
[x] 4. Imo socials, sponsors and footer links should open in a new tab. Use rel="noopener" to help with security if you do decide to do that.
[x] 5. The sponsors transition on hover could perhaps be sped up a little. QRT, the LRQA part of nettitude, accenture and tpp are also quite hard to read against the dark background. Also the fact that when you hover on QRT it first goes bright white then fades to dark is a bit strange. (Also applies to other places on the website)
[ ] 7. If you can be bothered, use alt text for all images for accessibility
[x] 8. Having a hover state for the footer icons could be cool
[x] 9. Is having the dark news thing intended on light mode?
[x] 10. The icon and heading for each category isn't vertically aligned on mobile
[x] 11. Not sure if the left margin/padding is intentional on Our Community
[x] 12. The open graph title has leading and trailing spaces for some reason
[x] 13. Not sure if we want to use that as the open graph image. If so, perhaps we could make a more high res version or replace it with some other image more suited to social media.
[ ] 14. This is much more personal pref, but maybe this would look better if the line height was increased slightly?