search

UWCubeSat / hsl-website

Website hosted at huskysat.org
MIT License
5 stars 2 forks source link

Progress #13

Closed manforowicz closed 1 year ago

manforowicz commented 1 year ago

Makes linked member cards fully clickable, without introducing any other changes. Fixes #10

netlify[bot] commented 1 year ago

Deploy Preview for huskysat ready!

Name Link
Latest commit 944c5bc32d1dc731c768a3334c360abd1bd81a3c
Latest deploy log https://app.netlify.com/sites/huskysat/deploys/6508f1eb9421a6000882ffd9
Deploy Preview https://deploy-preview-13--huskysat.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AlnisS commented 1 year ago

Looks great!

Some GitHub technicalities:

The previous commits from the progress branch were squashed, so this PR has somewhat funky changes in the change summary since it also includes the previous commits in the progress branch.

I cherry picked the commit onto a new branch add-member-card-link and created #14 to manage it - you should be assigned as a reviewer there, so feel free to review & merge it.

In the future, let's make a separate branch for each feature, and then we can squash merge + delete the branch when the feature is finished. Squashing avoids having all of the in-progress commits and keeps it to one with all the changes.

Thanks!