search

UWFlow / rmc

Flow is a website that lets you plan courses with friends.
https://uwflow.com
MIT License
233 stars 73 forks source link

fixed add to shortlist button when logged out issue #235 #237

Closed sachdevs closed 9 years ago

sachdevs commented 9 years ago

For #235, the only thing I'm unsure about here is the fact that I had to do a require('user') here since its a circular dependency, is that okay? Is there any other way to check if user is logged in that I am overlooking? Also we could put this check into a utility function since it may be used in other places.

mduan commented 9 years ago

Thanks for the fix! Tested locally, and it looks good. Mostly just some code style comments.