Closed JGulbronson closed 6 years ago
I think it looks good!
In my humble opinion, I don't think the red adds any value. Rather, to me it looks more convoluted and confuses the intent of the bar. For example, looking at the useful bar, is 51% useful a good thing or a bad thing? What I would suggest instead would be to drop two colours at the same time and instead make red appear until a threshold (say 25%). In code it would look something like this:
// in server/static/js/ratings.js
let color = "bar-success"
if (percent < 25) {
color = "bar-danger"
}
// add color class to your element
Apologies for my broken Javascript but you get the point. Thoughts?
@JGulbronson Can you either merge or close this please?
Not sure how I feel about this one.. I've had it requested though, so figured I'd put it up and see what people think. Especially makes it clear when a course has 0%.