UWFlow / rmc

Flow is a website that lets you plan courses with friends.
https://uwflow.com
MIT License
233 stars 73 forks source link

Export to Google Calendar comes out blank #347

Closed KMFSousa closed 5 years ago

KMFSousa commented 5 years ago

Issue: Looks like when I export my schedule the calendar is created but no events where in the calendar.

Prior State: I had a "uwflow.com schedule" calendar already from a previous term. After exporting the first time I deleted it and tried again and it was still blank.

Thoughts: Wondering if the events ended up in a wrong year, or if the .ics is just blank entirely.

AyushK1 commented 5 years ago

Hi! Thanks for posting this issue. We're looking into it. I'll update this thread as we progress towards resolution.

KMFSousa commented 5 years ago

@AyushK1 Hey, looks like it did eventually update. There was some sort of delay in the service. If this is common we should probably give a pop up or notification as such.

Mitchell Strong also had an issue like this. He did not delete his older calendar and it never updated (going on 2 days since he tried to add it via the export a couple times)

dshynkev commented 5 years ago

It seems that Google Calendar caches calendars in some unspecified way, such that our caching policy has no effect on retention time on their side. Removing the subscription and adding it again will not help; the caching appears to be globally keyed on the URL. In fact, even different Google accounts will see the same unupdated calendar when using the same URL.

It is expected that eventually every calendar should update, but it is not clear how long this can take at most or what the best way to handle this on our side is. We are continuing our investigation.

KMFSousa commented 5 years ago

Sounds like that means it’s a limitation from a Google. If that’s a case we should file a bug against them. (Feedback through Calendar might work. Click (?) then click ‘Send Feedback’)

In the mean time a notice that a delay will likely occur would avoid that annoyance.

jlfwong commented 5 years ago

I wonder if it might work to be able to generate a new google calendar URL and invalidate the old URL path completely. Google calendar would then invalidate their cache. It might even work to tack on random URL parameters that do nothing.

dshynkev commented 5 years ago

@jlfwong this does work, yes, and some in fact recommend it. We're still trying to see if it's possible to avoid that.

This issue has been reported to Google and a similar one was reported to Microsoft a long time ago.

AyushK1 commented 5 years ago

@KMFSousa we have deployed a fix which generates a new calendar URL every export. This should resolve the issue. Let us know if it crops up again!