UWIT-IAM / uw-idp-custom

Local IdP configuration and etc customizations
0 stars 0 forks source link

Resolve deprecation warnings #49

Closed mar235av closed 2 months ago

mar235av commented 5 months ago

The most significant part of the upgrade to Shibboleth v5.X is that some components have been deprecated. Fortunately, the last 4.X version set warning messages for all such cases. We need to identify our use of deprecated features and modify our deployment accordingly.

mar235av commented 4 months ago

Scanned and found five deprecation warnings:

2024-06-18 00:00:01,338 - WARN [DEPRECATED:135] - Spring bean 'shibboleth.HttpServletRequest': This will be removed in the next major version of this software; replacement is shibboleth.HttpServletRequestSupplier 2024-06-18 08:53:56,865 - WARN [DEPRECATED:135] - Spring bean 'shibboleth.HttpServletResponse': This will be removed in the next major version of this software; replacement is shibboleth.HttpServletRespoonseSupplier 2024-06-18 11:21:52,275 - WARN [DEPRECATED:128] - xsi:type 'SAML2NameID', (file [/data/local/idp/conf/attribute-resolver.xml]): This will be removed in the next major version of this software; replacement is (none) 2024-06-18 11:21:56,045 - WARN [DEPRECATED:135] - Spring bean 'shibboleth.NonCachingHttpClient': This will be removed in the next major version of this software; replacement is shibboleth.HttpClientFactory 2024-06-18 11:21:57,653 - WARN [DEPRECATED:110] - property 'idp.service.attribute.registry.namingRegistry' is no longer supported

mar235av commented 4 months ago

Fixed with several steps:

  1. The first two warning were fixed by changing definitions in conf/global.xml, requiring compatible changes to conf/authn/mfa-authn-config.xml, per release notes for version 4.0.0 and HttpClient configuration.
  2. The third warning was actually not deprecated in version 5.X, contrary to prior notice. We should investigate this, but this doe snot impact the upgrade.
  3. The fourth warning was fixed by changing the reference in conf/global.xml as noted in the warning.
  4. The last warning was a result of an old properties file inadvertently imported into the configuration. I removed that which resolved this warning.
chmc3 commented 2 months ago

This effort was completed with the release of idP v5 on 2024-08-13