search

UWIT-IAM / uw-idp-custom

Local IdP configuration and etc customizations
0 stars 0 forks source link

Additional deprecation warning #73

Closed mar235av closed 2 weeks ago

mar235av commented 1 month ago

While deploying our batch of configuration updates I noticed another deprecation warning in the Shibboleth logs that needs to be addressed:

2024-07-17 17:08:28,661 - WARN [DEPRECATED:135] - Java class method 'Passing a Collection to IdpAttribute#setValues()': This will be removed in the next major version of this software; replacement is List

This occurred when testing the OIDC link on urizen. I suspect that this is part of the attribute framework. This is somewhat concerning as it indicates that the warning is triggered only for a specific use case. I did a quick scan for other deprecation warnings and found none, but we will need some extra scanning to make sure we don't miss a case we haven't seen thus far.

mar235av commented 1 month ago

After I upgraded to Shibboleth 5.1.2, this warning became an error that caused a crash with a stack trace, allowing me to identify the exact place in the resolver that needed to be changed (actually two different places). This resolves the known issue. For possible additional issues, I will need to review all the data connectors defined in the attribute resolver and make sure that they are activated by our tests so that we can be confident that they work. The errors were in custom scripts that performed parts of the data loading steps.

mar235av commented 1 month ago

Another work item: many of our views contain a deprecated reference to the RelyingPartyContext (change of package name). I need to do a search/replace on all of these to resolve that deprecation.

chmc3 commented 2 weeks ago

This effort was completed with the release of idP v5 on 2024-08-13