UWMRO / Focuser

Code for automating focus of the MRO telescope
Apache License 2.0
1 stars 0 forks source link

Tests #7

Open darrenhunt2 opened 4 years ago

darrenhunt2 commented 4 years ago

Need review on the code (both Jupyter Notebook and Python file) uploaded to the test branch.

parejkoj commented 4 years ago

Thanks for this. I've been playing with the notebook some, and I think the next thing we need to figure out is whether there's a value from find_stars that gives us the information we need (something related to the FWHM) or not. From what I can tell, the sharpness in the output table is not what we're looking for.

I've done some more reading, and it's not clear whether photutils can in fact do the calculation we need. I've asked some astropy folks for software suggestions. We can always do a manual fit at the position of the brightest centroid using astropy.modeling.functional_models.Gaussian2D, but it would be nice if we didn't have to.

We need to check that the various images are actually of the same sources: for the August 18 data, the "focus6000" image appears to be a completely different field!

parejkoj commented 4 years ago

Next steps:

parejkoj commented 4 years ago

Oh, and please rename the branch to something more descriptive. "add_focus_test_files" maybe?