Open darrenhunt2 opened 4 years ago
Thanks for this. I've been playing with the notebook some, and I think the next thing we need to figure out is whether there's a value from find_stars
that gives us the information we need (something related to the FWHM) or not. From what I can tell, the sharpness
in the output table is not what we're looking for.
I've done some more reading, and it's not clear whether photutils
can in fact do the calculation we need. I've asked some astropy folks for software suggestions. We can always do a manual fit at the position of the brightest centroid using astropy.modeling.functional_models.Gaussian2D
, but it would be nice if we didn't have to.
We need to check that the various images are actually of the same sources: for the August 18 data, the "focus6000" image appears to be a completely different field!
Next steps:
Unzip all of the data into tests/data
, so that it's all in one place. Then we can write some tests against it in tests/
.
Once it's unzipped, go through each date's data and check that all the data in a given date is of a single field and delete any images that are of a different field. I know the 08.18 data has at least one file like this.
I don't believe that the focuser position is given in the headers. I've filed #8 about that. For now, we'll have to decide on a filename format that we can automate the extraction of the focuser position from. focusNNNN.fits
is the current format, but maybe we want something else so that we can have multiple images at the same focus position (e.g. focus_5000_long.fits
in 06.24). Please think about how to format all the files consistently like this and propose a filename format.
Oh, and please rename the branch to something more descriptive. "add_focus_test_files" maybe?
Need review on the code (both Jupyter Notebook and Python file) uploaded to the test branch.