UWMadisonUcomm / uw-ui-toolkit

A web front-end toolkit based on Bootstrap for designing and developing modern, mobile-first websites for the University of Wisconsin-Madison
Apache License 2.0
16 stars 15 forks source link

Integrate MyUW with UW UI Toolkit #55

Closed jhanstra closed 9 years ago

jhanstra commented 9 years ago

This pull request adds a namespaced section of the toolkit for MyUW redesign styles, per the discussion Phyllis, Vidal, Nick, and I had last week.

Namespace and Structure

There is a new tab in the nav for MyUW, which showcases the styles added and gives some info about how these styles are namespaced. All MyUW frame styles are namespaced under the class .my-uw and found in uw-myuw-frame.less, including the frame around the portlets. All styles within portlets are namespaced under the class .up-portlet-content-wrapper and are found in uw-myuw-site.less. These two new less files are found in a new folder, 'my-uw', under src/less/uw-ui-toolkit.

Tweaks to main codebase

The only changes made to the UW UI Toolkit more broadly (not namespaced specifically to MyUW) were to use container-fluid instead of container (more responsive) and to give the page headers a darker underline. I have a few more suggestions for broad changes, but I will reserve them for future changesets.

.container-fluid { margin-top:50px; }

.page-header { border-bottom:1px solid #600; padding-bottom:3px; }

Sorry this pull request is so huge! Most of it is just the distribution css though. Let me know what you think and if you have any suggestions/comments/feedback.

Thanks!

jnweaver commented 9 years ago

Thanks Jared!

I just started looking at this and making a few changes in response to this (e.g. with the container-fluid changes, making other parts of the toolkit site also use continaer-fluid -- I want to check with Vidal on this change though. I know the main reason we use container instead of container-fluid is to cap a max-width on really wide screen so line length doesn't become too long and thus less readable.)

Aside from that, I think this looks pretty good.

I did find myself wanting to rename uw-myuw-site.less to uw-myuw-portlet.less -- it feels like a better name even though I know there's a desire to move away from the word portlet. But for developers, I don't think it would be an issue and that is what Uportal still calls them. If not portal, then maybe we could name it uw-myuw-app.less?

I'm also still thinking over a few others things about this:

jhanstra commented 9 years ago

@jnweaver sorry for the delay!

I'll update this changeset with these changes. Let me know if you and/or @VidalQuevedo want to meet up to talk through these topics before merging.

Thanks!