UWMadisonUcomm / uw-ui-toolkit

A web front-end toolkit based on Bootstrap for designing and developing modern, mobile-first websites for the University of Wisconsin-Madison
Apache License 2.0
16 stars 15 forks source link

Cleanup Toolkit examples and navbar styling #78

Closed jnweaver closed 9 years ago

jnweaver commented 9 years ago

Apologies @jhanstra for this large set of changes. I did some long overdue cleanup of the examples in the Toolkit (trying to get this ready for prime time).

The vast majority of these changes all happen within the various *-classic class scopes and won't impact MyUW at all.

But I did also make some changes to /src/less/uw-ui-toolkit/uw-navbar.less and some of those selectors exist within MyUW too.

I've run through all of these navbar changes comparing them against MyUW production beta markup/DOM. These are the changes that would affect the MyUW navbar:

.navbar-toggle

.navbar-toggle .icon-bar

.navbar-collapse

All other changes should not impact My UW, but can you do a quick test against this branch? YOu might want to adjust margin-top on .navbar-toggle a pixel or two to push the button down a bit (it's a slightly smaller button now with slightly more pronounced hamburger bars.)

Also, I butchered the history on your most recent commits but those changes are reflected in here.

Thanks

jhanstra commented 9 years ago

Looks good! The changes to the navbar toggle are fine with me. :+1: