search

UWMadisonUcomm / uw-ui-toolkit

A web front-end toolkit based on Bootstrap for designing and developing modern, mobile-first websites for the University of Wisconsin-Madison
Apache License 2.0
16 stars 15 forks source link

My UW Font Awesome draconian widget style #90

Closed smargovsky closed 9 years ago

smargovsky commented 9 years ago

Despite my flavor for the dramatic, the following style :

in src/less/uw-ui-toolkit/my-uw/widget.less

.widget-body .fa {
  font-size:14px;
  padding:0px;
}

causes Font Awesome size classes ( fa-2x, etc ) to not be respected in widgets. @timlevett, how does your circle button directive get around this?

Would removing this bit mess up other My UW widget styles?

timlevett commented 9 years ago

Heh, interesting. That is true @smargovsky we shouldn't set that. I'm not sure how <circle-button> is not effected by this. or are you saying it is effected by this.

@jhanstra - we should review everywhere we are setting global styling for .fa and evaluate the "why".

timlevett commented 9 years ago

@smargovsky - your answer is, we haven't implemented <circle-button> in a widget yet (we have things that look like it, but are not it).

timlevett commented 9 years ago

@jhanstra - checkout https://fortawesome.github.io/Font-Awesome/examples/ for examples of what we can do with font-awesome. We should try to respect these styles in uw-ui-toolkit

smargovsky commented 9 years ago

Solved by https://github.com/UWMadisonUcomm/uw-ui-toolkit/issues/92